Fix constructor regression #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichernev
force-pushed
the
fix-constructor
branch
from
e92c79e
to
87c9ae9
Compare
| @@ -58,7 +58,7 @@ var updateInProgress = false; | |||
| // Moment prototype object | |||
| export function Moment(config) { | |||
| copyConfig(this, config); | |||
| this._d = new Date(config._d.getTime()); | |||
| this._d = new Date(config._d != null ? config._d.getTime() : NaN); | |||
There was a problem hiding this comment.
Should be !==, yes? Or could _d be undefined instead of null?
There was a problem hiding this comment.
No. != null catches null and undefined. In our case its actually undefined.
There was a problem hiding this comment.
Ok. Just making sure. Thanks.
|
LGTM |
|
My bad. +1 for more tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by https://github.com/moment/moment/pull/2368/files#diff-e792da0601bb2705000e86ef203f8e73R61
We should have had a test to cover for this case :)
Fix for #2512