Fix #2645 - invalid dates pre-1970 #2646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ export function createDate (y, m, d, h, M, s, ms) { | |||
| var date = new Date(y, m, d, h, M, s, ms); | |||
|
|
|||
| //the date constructor doesn't accept years < 1970 | |||
| if (y < 1970) { | |||
| if (y < 1970 && isFinite(date.getYear())) { | |||
|
Hmmm... somehow my change from #2465 appears to have been lost here. Can you redo that here please? The test should be |
|
@mj1856 your change from #2465 is not currently in the develop branch. When the time comes to resolve a potential merge conflict, I hope the individual responsible for resolving said conflict will reference this communication thread and merge appropriately. It is not, however, my responsibility to resolve before the fact a merge conflict that may or may not occur. |
|
Merged in cedef93 |
ichernev
added a commit
that referenced
this pull request
Nov 9, 2015
Fix #2645 - invalid dates pre-1970
ichernev
added a commit
that referenced
this pull request
Dec 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2645