New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2645 - invalid dates pre-1970 #2646

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@elreimundo

elreimundo commented Oct 2, 2015

Fixes #2645

@@ -4,7 +4,7 @@ export function createDate (y, m, d, h, M, s, ms) {
var date = new Date(y, m, d, h, M, s, ms);
//the date constructor doesn't accept years < 1970
if (y < 1970) {
if (y < 1970 && isFinite(date.getYear())) {

This comment has been minimized.

@mj1856

mj1856 Oct 2, 2015

Member

getFullYear

@mj1856

This comment has been minimized.

Member

mj1856 commented Oct 2, 2015

Hmmm... somehow my change from #2465 appears to have been lost here. Can you redo that here please? The test should be y < 100 && y >= 0 - not y < 1970. And the comment should be updated as well. Thanks.

@mj1856 mj1856 added this to the 2.10.7 milestone Oct 2, 2015

@elreimundo

This comment has been minimized.

elreimundo commented Oct 5, 2015

@mj1856 your change from #2465 is not currently in the develop branch. When the time comes to resolve a potential merge conflict, I hope the individual responsible for resolving said conflict will reference this communication thread and merge appropriately. It is not, however, my responsibility to resolve before the fact a merge conflict that may or may not occur.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

Merged in cedef93

@ichernev ichernev closed this Nov 9, 2015

ichernev added a commit that referenced this pull request Nov 9, 2015

ichernev added a commit that referenced this pull request Dec 23, 2015

sereysethy added a commit to sereysethy/moment that referenced this pull request Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment