New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2640: support instanceof operator #2648

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@alburthoffman
Contributor

alburthoffman commented Oct 5, 2015

refer to #2640, add code to support instanceof operator and make tests.

alburthoffman added some commits Oct 5, 2015

@mj1856

This comment has been minimized.

Member

mj1856 commented Oct 13, 2015

I can see that this will work, but I'm wondering if there could be unforeseen side effects. The current moment.prototype points at the utils_hooks__hooks function. This seems rather deliberate.

@ichernev @timrwood

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

@mj1856 you're wrong. The current moment.prototype is the default prototype for all created objects -- an empty object (I verified that with a simple test). So this should be safe to merge.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 9, 2015

Merged in aee4e2f

@ichernev ichernev closed this Nov 9, 2015

ichernev added a commit that referenced this pull request Nov 9, 2015

Merge pull request #2648 from alburthoffman:instanceof
fix issue #2640: support instanceof operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment