Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2640: support instanceof operator #2648

Closed
wants to merge 2 commits into from

Conversation

alburthoffman
Copy link
Contributor

refer to #2640, add code to support instanceof operator and make tests.

@mattjohnsonpint
Copy link
Contributor

I can see that this will work, but I'm wondering if there could be unforeseen side effects. The current moment.prototype points at the utils_hooks__hooks function. This seems rather deliberate.

@ichernev @timrwood

@ichernev
Copy link
Contributor

ichernev commented Nov 9, 2015

@mj1856 you're wrong. The current moment.prototype is the default prototype for all created objects -- an empty object (I verified that with a simple test). So this should be safe to merge.

@ichernev
Copy link
Contributor

ichernev commented Nov 9, 2015

Merged in aee4e2f

@ichernev ichernev closed this Nov 9, 2015
ichernev added a commit that referenced this pull request Nov 9, 2015
fix issue #2640: support instanceof operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants