Add convenience methods for date comparisons #2709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nscornia
commented
Oct 28, 2015
nscornia
commented
- isSameOrAfter
- isSameOrBefore
|
+1 |
|
@nscornia you need to add tests. |
|
Sure I can write some up. I just wasn't sure since there wasn't any new logic added. |
|
There is new API added... logic an implementation detail. |
|
Ok, I've added the tests, but it looks like the Travis build is failing on a completely unrelated test. Any advice? |
Added `isSameOrAfter` and `isSameOrBefore` convenience methods to Moment prototype and added test for new API
|
Nevermind, I got it fixed. |
|
Merged in 3ab9469 |
ichernev
added a commit
that referenced
this pull request
Dec 1, 2015
Add convenience methods for date comparisons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.