Year setter should keep time when DST changes #3036
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider:
It should have been
"2015-03-28T00:00:00+00:00"
While this only manifests when using moment-timezone, the problem is in moment itself. The
keepTime
flag of the year unit should be set totrue
, as it is for months, days, and hours.Fixed this, added some unit tests, and added similar tests around other units and related scenarios.