Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2762.
The consensus from that issue seemed to be that the presence of the
kk
token should not modify the value of other tokens, so that is the behavior that is implemented here.It should be noted that this decision introduces a bit of an inconsistency, given that the parsing behavior introduced here does change the day when an hour of 24 is present.
In other words,
I'm not extremely familiar with the internal codebase, so please let me know if there's anything that I did incorrectly or that I should add.