Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding updateLocale and defineLocale to typescript definition. #3135

Closed
wants to merge 2 commits into from

Conversation

tomvlk
Copy link
Contributor

@tomvlk tomvlk commented Apr 22, 2016

As the title says, adding definitions for the pretty new functions defineLocale and updateLocale for the moment interface.

@ichernev
Copy link
Contributor

ichernev commented Jun 7, 2016

Both define and update take the same second argument, and you have used 2 different types.

@tomvlk
Copy link
Contributor Author

tomvlk commented Jun 8, 2016

I updated the pull request.

@ichernev
Copy link
Contributor

Merged in 6d72a46

@ichernev ichernev closed this Jun 14, 2016
ichernev added a commit that referenced this pull request Jun 14, 2016
Adding updateLocale and defineLocale to typescript definition.
@ichernev ichernev mentioned this pull request Jun 16, 2016
@mattjohnsonpint mattjohnsonpint added this to the 2.14.0 milestone Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants