[bugfix] duration: parser: Support ms durations in .NET syntax #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would make it round. I understand that it's kind of a breaking change in the sense that the behavior changes, but it really does make more sense. If we have the data for the later decimal places we should use it. Maybe some people have to change their unit tests in some project as a result, but I'd consider that acceptable to fix what really is broken. |
|
Ok, I added the rounding behavior. |
not-an-aardvark
force-pushed
the
issue3266
branch
from
2783054
to
288a424
Compare
|
Any update on this? |
|
LGTM. @mj1856 this is your specialty - you like this? |
|
Yep. Looks great. Thanks! |
|
Merged in 6848096 |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Sep 1, 2016
[bugfix] duration: parser: Support ms durations in .NET syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3266
Note: The rounding behavior described in #3266 (comment) is not currently included in this PR, because it would break a number of existing tests. For example, with the proposed rounding behavior, the duration parsed in this test would haveseconds = 5andmilliseconds = 0.I can add the rounding behavior and change those tests if desired, but that might be considered a breaking change, so I thought it was worth bringing up the issue first. At the moment, extra millisecond digits are simply truncated rather than being rounded.edit: The rounding behavior has been added to this PR.