[bugfix] locales: Enable locale-data getters without moment (fixes #3284) #3312
Conversation
| @@ -99,17 +99,26 @@ function parseIsoWeekday(input, locale) { | |||
|
|
|||
| export var defaultLocaleWeekdays = 'Sunday_Monday_Tuesday_Wednesday_Thursday_Friday_Saturday'.split('_'); | |||
| export function localeWeekdays (m, format) { | |||
| if (typeof m === 'undefined') { | |||
There was a problem hiding this comment.
There's a utils.isUndefined. I forget what advantage it has, but we should be consistent.
|
This seems like a reasonable approach to me. @ichernev, what do you think? |
| return this._weekdaysShort[m.day()]; | ||
| } | ||
|
|
||
| export var defaultLocaleWeekdaysMin = 'Su_Mo_Tu_We_Th_Fr_Sa'.split('_'); | ||
| export function localeWeekdaysMin (m) { | ||
| if (typeof m === 'undefined') { | ||
| return this._weekdaysMin; | ||
| } | ||
| return this._weekdaysMin[m.day()]; | ||
| } |
There was a problem hiding this comment.
Wouldn't this code be cleaner as:
return (m) ? this._weekdaysMin[m.day()] : this._weekdaysMin;Also, this pull needs unit tests.
|
I have added unit tests and cleaned up the code. |
| @@ -12,6 +12,7 @@ import isArray from '../utils/is-array'; | |||
| import indexOf from '../utils/index-of'; | |||
| import { createUTC } from '../create/utc'; | |||
| import getParsingFlags from '../create/parsing-flags'; | |||
| import isUndefined from '../utils/is-undefined'; | |||
|
|
|||
There was a problem hiding this comment.
is this util being used? Note that my suggestion changed the meaning of the code. Previously you were checking for undefined, and now you're checking for falsiness. I think they achieve what amounts to the same thing, but I want to point out that semantic change.
There was a problem hiding this comment.
Ah, my bad. I forgot to remove that import. Will do that.
So should I use typeof m === 'undefined' or !m?
There was a problem hiding this comment.
Well, now you can drop the line :)
|
Can you point to the place in the docs that this behavior is documented? |
|
Merged in 626bd19 |
ichernev
changed the title
[bugfix] locales: Enable locale-datnwithout moment ta getters without moment (fixes #3284)
ichernev
changed the title
This possibly fixes the issue #3284. Can you please verify it @icambron ?
In the absence of a moment parameter, it returns a locale specific list.