[new locale] nl-be: Dutch (Belgium) locale

[kevinzwhuang]

These changes address issue #3410:

• Renames nl locale to nl-nl for Dutch (Netherlands) locale
• Creates nl-be for Dutch (Belgium) locale

References for nl-be locale:

• Locale Planet reference: http://www.localeplanet.com/java/nl-BE/
• IBM Documentation of nl-be: http://www.ibm.com/support/knowledgecenter/SSS28S_3.0.0/com.ibm.help.forms.doc/locale_spec/i_xfdl_r_formats_nl_BE.html

References for nl-nl locale:

• Locale Planet nl-nl reference: http://www.localeplanet.com/java/nl-NL/
• IBM Documentation of nl-nl: http://www.ibm.com/support/knowledgecenter/SSS28S_3.0.0/com.ibm.help.forms.doc/locale_spec/i_xfdl_r_formats_nl_NL.html

How does this look to you @jorisroling, @middagj?

[middagj]

I am Dutch (as in nl-nl), so I can't really comment on the standard Belgian way of writing dates. I do see it sometimes like that, and the linked sources do confirm. Is it possible to have a common ancestor of the two files?

(Sorry about the line comment, only if the month is numeric slashes are used so no need to change the if statement.)

[kevinzwhuang]

I just added a commit to restore the original src/locale/nl.js & src/test/locale/nl.js to serve as a common ancestor for both nl-nl & nl-be, does that work @middagj?

[middagj]

Oh that is also nice, for if you don't care about NL or BE. I was actually more referring to duplication in the code. I don't know if that is easily done in the current framework.

[kevinzwhuang]

Yeah, duplicating it as NL for now is probably the way to go. AR and the
other AR locales ( AR-LY, AR-MA, ...etc ) also follow this pattern ( see
ar.js, ar-ly.js, etc. )

This is nice too since anyone using NL currently will not suffer a breaking
change from losing the locale to NL-NL.

On Mon, Sep 5, 2016, 11:54 AM Jacob Middag notifications@github.com wrote:

Oh that is also nice, for if you don't care about NL or BE. I was actually
more referring to duplication in the code. I don't know if that is easily
done in the current framework.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3416 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG64ch7Qe_rOAsSPpm7TgbQ0Fr32V1cgks5qnGV9gaJpZM4JzdtT
.

[kevinzwhuang]

Revisiting this PR after a while, @mj1856 how does this look to you?

[mattjohnsonpint]

You don't need to do anything with nl, nor do you need a nl-nl copy. Just add the one file nl-be.js (and its tests).

Consider that moment.locale('nl-anything') will currently use nl.

[kevinzwhuang]

Thanks @mj1856 , I went ahead and removed nl-nl. Now the only addition will be nl-be and its tests

[kevinzwhuang]

Does this PR look good to you @mj1856 ?

[ichernev]

@kevinzwhuang code looks great. You'd also need to sing the CLA (a new thing). This will go out in next release. Thanks for contributing!

[kevinzwhuang]

Thanks @ichernev, just signed the CLA!

[ichernev]

Merged in 0ad3055