Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Durations gain validity #3611

Closed
wants to merge 11 commits into from
Closed

[feature] Durations gain validity #3611

wants to merge 11 commits into from

Commits on Nov 19, 2016

  1. Create _isValid property for durations

    @marwahaha
    marwahaha committed Nov 19, 2016
    Copy the full SHA
    5076d1f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2016

  1. Add accessor function to isValid

    @marwahaha
    marwahaha committed Nov 29, 2016
    Copy the full SHA
    f60a3f4 View commit details
    Browse the repository at this point in the history

  2. Return invalid date for humanize if duration is invalid

    @marwahaha
    marwahaha committed Nov 29, 2016
    Copy the full SHA
    81aa62d View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2016

  1. Replace arrow function

    @marwahaha
    marwahaha committed Nov 30, 2016
    Copy the full SHA
    35ee5a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2016

  1. Write duration-invalid tests

    @marwahaha
    marwahaha committed Dec 5, 2016
    Copy the full SHA
    0e71c08 View commit details
    Browse the repository at this point in the history

  2. Fix duration functions to follow tests

    @marwahaha
    marwahaha committed Dec 5, 2016
    Copy the full SHA
    d6afd97 View commit details
    Browse the repository at this point in the history

  3. Add second invalid duration test case

    @marwahaha
    marwahaha committed Dec 5, 2016
    Copy the full SHA
    b3604b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2017

  1. Add validity check for decimal values on non-smallest duration unit

    @marwahaha
    marwahaha committed Jan 21, 2017
    Copy the full SHA
    f95841e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2017

  1. Make easy changes as per code review

    @marwahaha
    marwahaha committed Feb 6, 2017
    Copy the full SHA
    058e741 View commit details
    Browse the repository at this point in the history

  2. Make rest of code review changes

    @marwahaha
    marwahaha committed Feb 6, 2017
    Copy the full SHA
    a78014d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2017

  1. Create moment.duration.invalid()

    @marwahaha
    marwahaha committed Feb 21, 2017
    Copy the full SHA
    4020a7d View commit details
    Browse the repository at this point in the history