[misc] TS: Make typescript definitions work with 1.x #3638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged in aedd0dd |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Dec 4, 2016
[misc] TS: Make typescript definitions work with 1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the definitions file from breaking changes introduced in #3490. Now the file is somewhat compatible with 2.0 with the use of
voidinstead ofundefined, but unfortunatelynullarguments are not supported with 2.x andstrictNullChecks, becausenullkeyword is not available in 1.x.The typescript definitions will be updated for 2.0 (proper
nullsupport) with the release of moment 3.x. NOTE Any requests to fix the definitions before that will be denied.NOTE2: For the eager 2.0 ts users -- the definition file includes in comments whether the
voidcorresponds to null, undefined, or both. So one can simply write a script to generate a proper 2.0 definition. The scope of this generator is not part of the moment team's efforts, so PRs won't be accepted.