New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fixes #3520, parseZone incorrectly handled minutes under 16 #3643

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@maggiepint
Member

maggiepint commented Dec 5, 2016

Fixes issue in #3520 where explicitly parsed offset in minutes less than abs(16) is converted to hours.

@icambron

This comment has been minimized.

Member

icambron commented Dec 5, 2016

LGTM

@maggiepint

This comment has been minimized.

Member

maggiepint commented Dec 5, 2016

Note: the .vscode in the .gitignore allows moment to be used with Visual Studio Code's node debugger. Given how popular the editor has become, I can't see that it hurts.

@icambron

This comment has been minimized.

Member

icambron commented Dec 5, 2016

@maggiepint In theory you should block that in your global .gitignore file. In practice I agree it doesn't hurt.

@mj1856 mj1856 modified the milestone: 2.18.0 Jan 17, 2017

@ichernev

This comment has been minimized.

Contributor

ichernev commented Feb 4, 2017

LGTM

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 2, 2017

Merged in 5c54613

@ichernev ichernev changed the title from fix conversion of parsed offset to hours to [bugfix] Fixes #3520, parseZone incorrectly handled minutes under 16 Mar 2, 2017

@ichernev ichernev closed this Mar 2, 2017

ichernev added a commit that referenced this pull request Mar 2, 2017

Merge pull request #3643 from moment:maggie/offsetminutesashours
[bugfix] Fixes #3520, parseZone incorrectly handled minutes under 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment