[bugfix] Fixes #3632, toISOString returns null for invalid date #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Since @icambron seems to like it, and I like it cuz I wrote it :-) marking with a |
|
Merged in e4364f5 |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Mar 2, 2017
[bugfix] Fixes #3632, toISOString returns null for invalid date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves #3632 and replaces #3644 with a less invasive solution.
Basically,
.toISOString()now returns null if called on an invalid date.There was also some mad cyclomatic complexity in there that I cleaned up.