[feature] Enable relative time for multiple seconds, request #2558 #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichernev
reviewed
Mar 5, 2017
| @@ -60,6 +63,11 @@ export function getSetRelativeTimeThreshold (threshold, limit) { | |||
| if (limit === undefined) { | |||
| return thresholds[threshold]; | |||
| } | |||
| if (threshold === 's' && !secondsThresholdChanged) { | |||
There was a problem hiding this comment.
This is a bit tricky. I'd drop the variable, always set ss to limit - 1, so if you need to use it you need to set ss last (alone or after s, which makes sense).
There was a problem hiding this comment.
Thanks for the feedback, doing the cleanup and the merge! :)
|
@pndewit its valid, just clean it a bit as requested and it'll be merged. |
|
Also make a corresponding PR to the docs repo: https://github.com/moment/momentjs.com |
|
Merged in ed1fc74 |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Mar 11, 2017
[feature] Enable relative time for multiple seconds, request #2558
|
Docs PR created: moment/momentjs.com#404 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional threshold (
ss) fora few secondsto%d seconds. It is built so that it will never display%d secondsUNLESS the user manually sets thessthreshold. Setting thessthreshold once will separate the default value (which is the value in thesthreshold minus 1).As mentioned in #2558, there is no translation for:
%d seconds. I could add this for each locale using thesecondsword that is already present in each locale for thesthreshold (e.g.a few **seconds**), but I don't know if this would work for all locales. So then this would require a review from a native speaker for each locale. Probably not gonna happen.#2182: I hope by not actively using this
ssthreshold by default (afaik this is backwards compatible), this PR still has a chance.Let me know what you think :)