[feature] Add support for k and kk format parsing #3766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k and kk parsing support behaves the same as H and HH, except for the value 24 that is treated as the 0 value for the HOUR field.
I had a concern about how to treat the 25 value, since
moment("24:00", "HH:mm")
is valid butmoment("24:50", "HH:mm")
is not;moment("25:00", "kk:mm")
could be valid (setting the hour field to 1), but in the end that seemed counterintuitive.Any thoughts are welcomed.
Hope this helps.