New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Fix invalid whitespace character causing inability to parse moment.js #3853

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
6 participants
@shmendo

shmendo commented Mar 21, 2017

Please see the attached screenshots from Chrome 56.0.2924.87.

It appears there is an invalid whitespace character in the source code in src/lib/locale/set.js. I removed that character and added a standard space which appears to have fixed the problem. I still ran the tests and confirmed all passed.

This can be reproduced by adding the following index.html file in the repo at the root of the project and loading it in chrome.

I should note that I put the whitespace replacement into the file referenced above, then ran grunt release and confirmed that it did indeed fix the issue.

# index.html
<html>
<head>
  <script src="moment.js"></script>
</head>
<body>
</body>
</html>

screen shot 2017-03-20 at 7 52 21 pm

screen shot 2017-03-20 at 7 52 41 pm

Benjamin Walters
@jesstelford

jesstelford approved these changes Mar 21, 2017 edited

This fixes the same issue we were having, which was breaking all our builds (as moment is a dep of a dep, we can't roll back... The dark side of semver ranges). Thanks for tracking it down!

cc @ichernev

@gpoole

gpoole approved these changes Mar 21, 2017

@shmendo shmendo changed the title from Fixed issue with an invalid whitespace character to Fixed invalid whitespace character causing inability to parse moment.js Mar 21, 2017

@shmendo

This comment has been minimized.

shmendo commented Mar 21, 2017

Thanks guys! After looking at some open issues I may try and help out in that respect as time allows. Appreciate the warm welcome :)

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 21, 2017

I'll cut a release in around 5hrs

@shmendo

This comment has been minimized.

shmendo commented Mar 21, 2017

YTMND @ichernev

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 21, 2017

Merged in 863f861

@ichernev ichernev changed the title from Fixed invalid whitespace character causing inability to parse moment.js to [misc] Fix invalid whitespace character causing inability to parse moment.js Mar 21, 2017

@ichernev ichernev closed this Mar 21, 2017

ichernev added a commit that referenced this pull request Mar 21, 2017

Merge pull request #3853 from shmendo:develop
[misc] Fix invalid whitespace character causing inability to parse moment.js
@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 21, 2017

Enjoy 2.18.1

@wimrijnders

This comment has been minimized.

wimrijnders commented Mar 28, 2017

Hi guys,

Has this fix been released yet? We're getting loads of issues about this in our project graph3d.

Edit: Never mind. I just figured out if we do a release ourselves, the issue will be fixed.

mojoaxel added a commit to almende/vis that referenced this pull request Mar 28, 2017

@mojoaxel mojoaxel referenced this pull request Mar 28, 2017

Merged

updated moment.js #2925

bradh added a commit to almende/vis that referenced this pull request Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment