-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Fix invalid whitespace character causing inability to parse moment.js #3853
Conversation
…browser during parsing in Chrome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the same issue we were having, which was breaking all our builds (as moment
is a dep of a dep, we can't roll back... The dark side of semver ranges). Thanks for tracking it down!
cc @ichernev
Thanks guys! After looking at some open issues I may try and help out in that respect as time allows. Appreciate the warm welcome :) |
I'll cut a release in around 5hrs |
YTMND @ichernev |
Merged in 863f861 |
[misc] Fix invalid whitespace character causing inability to parse moment.js
Enjoy 2.18.1 |
Hi guys, Has this fix been released yet? We're getting loads of issues about this in our project graph3d. Edit: Never mind. I just figured out if we do a release ourselves, the issue will be fixed. |
see moment/moment#3853 fixes #2912
see moment/moment#3853 fixes #2912
see moment/moment#3853 fixes #2912
see moment/moment#3853 fixes #2912
see moment/moment#3853 fixes #2912
Please see the attached screenshots from Chrome 56.0.2924.87.
It appears there is an invalid whitespace character in the source code in
src/lib/locale/set.js
. I removed that character and added a standard space which appears to have fixed the problem. I still ran the tests and confirmed all passed.This can be reproduced by adding the following index.html file in the repo at the root of the project and loading it in chrome.
I should note that I put the whitespace replacement into the file referenced above, then ran
grunt release
and confirmed that it did indeed fix the issue.