New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsnext:main -> module #3904

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
4 participants
@jsf-clabot

This comment has been minimized.

jsf-clabot commented Apr 10, 2017

CLA assistant check
All committers have signed the CLA.

@maggiepint

This comment has been minimized.

Member

maggiepint commented Apr 22, 2017

Yep. That's correct these days.

@ichernev

This comment has been minimized.

Contributor

ichernev commented May 1, 2017

@evan-scott-zocdoc maybe stupid question but does this fix the webpack all-languages-together issue or a separate problem.

@ichernev

This comment has been minimized.

Contributor

ichernev commented May 1, 2017

Talking about this webpack/webpack#3128 (comment)

@evan-scott-zocdoc

This comment has been minimized.

Contributor

evan-scott-zocdoc commented May 5, 2017

I don't think it would, no. Not unless the library switched to using the function variant of import (import(path).then()) which isn't standard yet AFAIK.

@maggiepint maggiepint merged commit aea6a97 into moment:develop Aug 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

orif-jr pushed a commit to orif-jr/moment that referenced this pull request Aug 3, 2017

Bofanda Bofanda
Merge branch 'develop' into my-develop
* develop:
  Added Gujarati locale for moment (moment#4004)
  Add bambara language. (moment#4001)
  NL and BE locale weekDaysMin should not be capitalized, updated to lowercase. (moment#3961)
  moment#1428: Updated Danish 'L' dateformat to use dots rather than slashes, aligning with article from DSN. (moment#3945)
  update travis to only test back to node 4
  jsnext:main -> module (moment#3904)
  Fix localeData months on Greek (moment#3868)
  Fix moment#4060: bundle.generate returns a Promise now
  compute monthDiff only for the type that needs it
  convert long ternary operator to switch for easier readability
  Changed setter check behavior to use isNaN() for checking whether an input is a valid value
  Removed unwarranted spaces, changed illegal quotes
  Added semicolon to helper
  Added new line in helper file
  Added helper 'isNumeric' to test values for validity in setters
  Update for  check,
  Added comment as requested in: moment#3504
  Fix for conditional in src/lib/units/offset.js:164 - I interpreted this is as simply not catching  being a falsy (but assumedly valid) time zone modifier (_tzm?) of 0

ichernev added a commit to ichernev/moment that referenced this pull request Oct 10, 2017

ichernev added a commit to ichernev/moment that referenced this pull request Oct 10, 2017

ichernev added a commit that referenced this pull request Oct 10, 2017

Merge pull request #4226 from ichernev:revert-package-json-es6
[critical] Revert "jsnext:main -> module (#3904)", fixes #4216

fbonzon added a commit to fbonzon/moment that referenced this pull request Oct 28, 2017

fbonzon added a commit to fbonzon/moment that referenced this pull request Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment