New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[critical] Move require rename inside try/catch #4214

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@ichernev
Contributor

ichernev commented Oct 10, 2017

This is a fixup to #4213

@ichernev

This comment has been minimized.

Contributor

ichernev commented Oct 10, 2017

Merged in 6115ae5

@ichernev ichernev changed the title from Move require rename inside try/catch to [critical] Move require rename inside try/catch Oct 10, 2017

@ichernev ichernev closed this Oct 10, 2017

@ichernev ichernev merged commit 79e9131 into moment:develop Oct 10, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
licence/cla Contributor License Agreement is signed.
Details

ichernev added a commit that referenced this pull request Oct 10, 2017

Merge pull request #4214 from ichernev:fixup-react-native-p2
[critical] Move require rename inside try/catch
@JesusGuerrero

This comment has been minimized.

JesusGuerrero commented on src/lib/locale/locales.js in 79e9131 Oct 11, 2017

using Angular 4/TypeScript/Babel the transpiler complained:

WARNING in ./node_modules/moment/src/lib/locale/locales.js Module not found: Error: Can't resolve './locale' in '/Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/src/lib/locale' resolve './locale' in '/Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/src/lib/locale' using description file: /Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/package.json (relative path: ./src/lib/locale) Field 'browser' doesn't contain a valid alias configuration after using description file: /Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/package.json (relative path: ./src/lib/locale) using description file: /Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/package.json (relative path: ./src/lib/locale/locale) as directory /Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/src/lib/locale/locale doesn't exist [/Users/bvc839/C1/Blueprint/dxin-producer-app/node_modules/moment/src/lib/locale/locale] @ ./node_modules/moment/src/lib/locale/locales.js 65:16-60 @ ./node_modules/moment/src/lib/locale/locale.js @ ./node_modules/moment/src/moment.js @ ./node_modules/chart.js/src/scales/scale.time.js @ ./node_modules/chart.js/src/chart.js @ ./src/app/apps/components/app-analytics/app-analytics.component.ts @ ./src/app/apps/apps.module.ts @ ./src/app/dxin.module.ts @ ./src/main.ts @ multi ./src/main.ts

I had to replace './locale/' with './' to silence the warning. Using moment as a dependency of chart.js which had a recent upgrade too.

This comment has been minimized.

bsvobodny replied Oct 11, 2017

I have the exact same warning and I'm using Aurelia/Typescript/Webpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment