revert locale fallbacks in require, re-add react native aliasing #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up PR to test webpack against builds coming soon. |
This was referenced Oct 11, 2017
|
This passes my MCVE. |
chamini2
reviewed
Oct 11, 2017
| // want to undo that for lazy loaded locales | ||
| getSetGlobalLocale(oldLocale); | ||
| oldLocale = globalLocale._abbr; | ||
| var aliasedRequire = require; |
There was a problem hiding this comment.
TBH I don't know why this makes metro-bundler work for React native, I just know that it does do that.
There was a problem hiding this comment.
This is still not working for a lot people because some react native modules e.g. react-native-gifted-chat are referencing moment-with-locales.min.js i.e. the minified version. For some reason, the minified version does not seem to have the fix.
When I fixed the code in moment-with-locales.min.js using your approach of aliasing "require", 2.19.1 began to work for me.
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts @ovangle's change from July to try a fallback try/catch for requiring locales. It maintains the change for react native of aliasing the require function. I pulled this change into webpack 2 and everything seems fine. In short, we appear to be able to mostly make everyone happy.