New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix incorrect strict parsing with full-width parentheses #4240

Merged
merged 2 commits into from Dec 17, 2017

Conversation

Projects
None yet
3 participants
@matthewdeeco
Contributor

matthewdeeco commented Oct 13, 2017

This fixes #2867

My solution was to exclude \uFF08 and \uFF09 which are and respectively.

@marwahaha marwahaha changed the title from Fix incorrect strict parsing with full-width parentheses to [bugfix] Fix incorrect strict parsing with full-width parentheses Dec 11, 2017

@marwahaha

This comment has been minimized.

Member

marwahaha commented Dec 11, 2017

@matthewdeeco - sorry we left this on the vine. Can you resolve the conflicts?

Merge remote-tracking branch 'upstream/master' into fix-incorrect-str…
…ing-parsing-with-ja-parens

Conflicts:
	src/lib/parse/regex.js

@marwahaha marwahaha merged commit 666a92f into moment:develop Dec 17, 2017

3 checks passed

Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment