Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix weekday verification for UTC and offset days (fixes #4227) #4332

Merged
merged 2 commits into from
Dec 11, 2017
Merged

[bugfix] Fix weekday verification for UTC and offset days (fixes #4227) #4332

merged 2 commits into from
Dec 11, 2017

Conversation

icambron
Copy link
Member

@icambron icambron commented Nov 29, 2017 •
edited
Loading

#4275 (fix for #4227) but with a few changes:

  • Don't create a local date every time, just pull the UTC day out of the UTC-constructed date
  • Some more tests

@icambron icambron changed the title redux of fixing weekday verification [bugfix] redux of fixing weekday verification Nov 29, 2017
@icambron icambron changed the title [bugfix] redux of fixing weekday verification [bugfix] Fix weekday verification for UTC and offset days Nov 29, 2017
@icambron icambron mentioned this pull request Nov 29, 2017
Closed
@ZachGawlik
Copy link
Contributor

Ah, I was unaware of getUTCDay. Much nicer than my hasty approach of converting to local date and extracting day after the fact. Neat!

@marwahaha marwahaha changed the title [bugfix] Fix weekday verification for UTC and offset days [bugfix] Fix weekday verification for UTC and offset days (fixes #4227) Dec 11, 2017
@marwahaha marwahaha merged commit 1c978ba into moment:develop Dec 11, 2017
This was referenced Dec 11, 2017
Merged
Merged
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichernev ichernev Awaiting requested review from ichernev

Assignees
No one assigned
Labels
Bug-fix High Priority Pending Next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icambron @ZachGawlik @marwahaha