New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix weekday verification for UTC and offset days (fixes #4227) #4332

Merged
merged 2 commits into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@icambron
Member

icambron commented Nov 29, 2017

#4275 (fix for #4227) but with a few changes:

  • Don't create a local date every time, just pull the UTC day out of the UTC-constructed date
  • Some more tests

ZachGawlik and others added some commits Oct 28, 2017

@icambron icambron requested a review from ichernev Nov 29, 2017

@icambron icambron changed the title from redux of fixing weekday verification to [bugfix] redux of fixing weekday verification Nov 29, 2017

@icambron icambron changed the title from [bugfix] redux of fixing weekday verification to [bugfix] Fix weekday verification for UTC and offset days Nov 29, 2017

@ZachGawlik

This comment has been minimized.

ZachGawlik commented Nov 29, 2017

Ah, I was unaware of getUTCDay. Much nicer than my hasty approach of converting to local date and extracting day after the fact. Neat!

@marwahaha marwahaha changed the title from [bugfix] Fix weekday verification for UTC and offset days to [bugfix] Fix weekday verification for UTC and offset days (fixes #4227) Dec 11, 2017

@marwahaha marwahaha merged commit 1c978ba into moment:develop Dec 11, 2017

3 checks passed

Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment