New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] fix deprecated rollup options #4371

Merged
merged 2 commits into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@JLHwung
Contributor

JLHwung commented Dec 22, 2017

The test fails due to we have used deprecated rollup options for a long time and recently rollup 0.53.0 will throw on unknown options. Since we always use the latest rollup, the error is thrown as-is.

This PR fixes the issue according to the deprecated warning on the older rollup options.

fixes #4373

@JLHwung JLHwung changed the title from fix(rollup): fix deprecated rollup options to [misc]: fix deprecated rollup options Dec 22, 2017

@JLHwung JLHwung changed the title from [misc]: fix deprecated rollup options to [misc] fix deprecated rollup options Dec 22, 2017

@marwahaha marwahaha requested a review from ichernev Dec 23, 2017

@marwahaha marwahaha merged commit a1b527f into moment:develop Dec 28, 2017

5 checks passed

Base branch Looks good!
Generated files No edits to generated files! :)
Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@JLHwung JLHwung deleted the JLHwung:fix-deprecated-rollup-options branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment