[bugfix] Fix #4390: use offset properly in toISOString #4391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was introduced in PR #4341.
I thought unit-tests using
utc()
andutcOffset(...)
were good enough, but the behaviour of moments in utc mode isn't the same as non-utc moments with local timezone offsets.I'm not sure how to create unit-tests for this, but PR continues to keep unit-tests passing, and I've checked behaviour by using this bash script:
Output: