Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg] #4186 Add sourceMaps for the minified version #4816

Closed
wants to merge 1 commit into from

Conversation

akanshgulati
Copy link

To add source maps on the minified version of moment.js to enable debugging on production environment.
Referring to issue #4186.

@jsf-clabot
Copy link

jsf-clabot commented Oct 16, 2018

CLA assistant check
All committers have signed the CLA.

@marwahaha marwahaha changed the title chore(Gruntfile.js): #4186 Add sourceMaps for the minified version [pkg]: #4186 Add sourceMaps for the minified version Oct 31, 2018
@marwahaha marwahaha changed the title [pkg]: #4186 Add sourceMaps for the minified version [pkg] #4186 Add sourceMaps for the minified version Oct 31, 2018
@marwahaha
Copy link
Member

@akanshgulati please don't edit min/*.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.5%) to 88.121% when pulling 0632935 on akanshgulati:fix-4186 into 2e2a5b3 on moment:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.5%) to 88.121% when pulling 0632935 on akanshgulati:fix-4186 into 2e2a5b3 on moment:develop.

@akanshgulati
Copy link
Author

@marwahaha it meant to generate the source maps only for minified versions only. What are you mentioning exactly?

@ichernev
Copy link
Contributor

This has already been implemented in 4dfe59b

@ichernev ichernev closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants