New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Upgrade some devDeps to fix vulnerabilities #4828
Conversation
f99571c
to
5e5a558
Compare
As I documented above, I don't think Node is doing the wrong thing here.
Why is it failing to parse? What are you using for your Unicode data , are you using pre-Unicode 11 tables? If so, this may be a case for tc39/ecma402#90 making Unicode properties available in ecma402. Then, you'd have access to the same Unicode version as the container. But i'm just speculating. |
@marwahaha please don't disable the |
@srl295 do you have a recommendation? It sounds like there's a bug in a Unicode library, but I'd like to get other things moving on this library. I'm happy to create another issue that (when solved/unblocked) will remove the test exceptions for |
@marwahaha / @srl295 I think it'd be good to merge this PR quickly (temporarily disabling Georgian.) The current scenario (where Georgian fails) means every contributor faces the frustrating situation where their PR fails for reasons totally unrelated to their changes. |
see #4839 |
@marwahaha it's a bug in v8. I will comment more on the follow up issue. |
This fixes builds and upgrades to mitigate some vulnerabilities.
fixes #4776
Notes:
toLocaleUpperCase() not working for Georgian locale ('ka') nodejs/node#22518