Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Upgrade some devDeps to fix vulnerabilities #4828

Merged
merged 8 commits into from Oct 31, 2018

Conversation

marwahaha
Copy link
Member

@marwahaha marwahaha commented Oct 21, 2018

This fixes builds and upgrades to mitigate some vulnerabilities.

fixes #4776

Notes:

  1. Node 10 has a current issue with the Georgian locale, documented here:
    toLocaleUpperCase() not working for Georgian locale ('ka') nodejs/node#22518
  2. Grunt should be upgraded to 1.0 to solve some security vulnerabilities, but we have to get off some old plugins in order to do that.

@marwahaha marwahaha changed the title Upgrade some devDeps to fix vulnerabilities [misc] Upgrade some devDeps to fix vulnerabilities Oct 21, 2018
@coveralls
Copy link

coveralls commented Oct 21, 2018

Coverage Status

Coverage decreased (-6.5%) to 88.175% when pulling c34344f on km/vulnerabilities into 2e2a5b3 on develop.

@marwahaha marwahaha changed the title [misc] Upgrade some devDeps to fix vulnerabilities [misc] Upgrade some devDeps to fix vulnerabilities Oct 22, 2018
@srl295
Copy link

srl295 commented Oct 22, 2018

As I documented above, I don't think Node is doing the wrong thing here.

Module: locale:ka Test: parse
ᲓᲔᲙᲔᲛᲑᲔᲠᲘ უნდა იყოს თვე 12

Why is it failing to parse? What are you using for your Unicode data , are you using pre-Unicode 11 tables? If so, this may be a case for tc39/ecma402#90 making Unicode properties available in ecma402. Then, you'd have access to the same Unicode version as the container. But i'm just speculating.

@srl295
Copy link

srl295 commented Oct 22, 2018

@marwahaha please don't disable the ka locale. Moment has a bug, see
#4762 (comment)

@marwahaha
Copy link
Member Author

@srl295 do you have a recommendation? It sounds like there's a bug in a Unicode library, but I'd like to get other things moving on this library.

I'm happy to create another issue that (when solved/unblocked) will remove the test exceptions for ka locale.

@ashsearle
Copy link
Contributor

@marwahaha / @srl295 I think it'd be good to merge this PR quickly (temporarily disabling Georgian.)

The current scenario (where Georgian fails) means every contributor faces the frustrating situation where their PR fails for reasons totally unrelated to their changes.

@marwahaha marwahaha merged commit 4f31adb into develop Oct 31, 2018
@marwahaha
Copy link
Member Author

see #4839

@srl295
Copy link

srl295 commented Oct 31, 2018

@marwahaha it's a bug in v8. I will comment more on the follow up issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package-lock.json version doesn't match release version (but package.json does)
4 participants