Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] './locale' path not found in moment/src/lib/locale/locales.js #5503

Closed
wants to merge 1 commit into from

Conversation

ApacheEx
Copy link

@ApacheEx ApacheEx commented May 3, 2020

seems root of issue was introduced here: 9ce89e7

So, this PR reverts it and fixes the following issues:
#4505, #5472, #5497, #5501, #5500, #5378, #5495, #5506, #5508

@jsf-clabot
Copy link

jsf-clabot commented May 3, 2020

CLA assistant check
All committers have signed the CLA.

@ApacheEx ApacheEx changed the title Remove module Fix './locale' path not found in moment/src/lib/locale/locales.js May 3, 2020
@ApacheEx ApacheEx changed the title Fix './locale' path not found in moment/src/lib/locale/locales.js [bugfix] './locale' path not found in moment/src/lib/locale/locales.js May 3, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 88.425% when pulling 7df7e6b on ApacheEx:patch-1 into 475a1e0 on moment:develop.

@ApacheEx
Copy link
Author

ApacheEx commented May 3, 2020

also, as possible fix:

replace "module": "./src/moment.js" to "module": "./moment.js"
but don't know exactly if this "module" is really needed at all and what was the reason to introduce it.

@J1445
Copy link

J1445 commented May 3, 2020

also, as possible fix:

replace "module": "./src/moment.js" to "module": "./moment.js"
but don't know exactly if this "module" is really needed at all and what was the reason to introduce it.

Can confirm this fixes #5495 the issue and you are the MVP here.

Also commit description is not clear in 9ce89e7

@nicolashenry
Copy link

nicolashenry commented May 3, 2020

FYI "module" is supposed to be an ecmascript module and "./moment.js" is a commonjs module. (https://webpack.js.org/guides/author-libraries/#final-steps)

@BuangHosen
Copy link

also, as possible fix:

replace "module": "./src/moment.js" to "module": "./moment.js"
but don't know exactly if this "module" is really needed at all and what was the reason to introduce it.

thanks sir, you save my day 👍

@FredrikSeidl
Copy link

Can confirm that this resolves it for us. Can this be merged and released on NPM soon?

@ApacheEx
Copy link
Author

ApacheEx commented May 4, 2020

ok guys, I see it's fixed in 2.25.2.

So, I'm closing this.

@ApacheEx ApacheEx closed this May 4, 2020
@ApacheEx ApacheEx deleted the patch-1 branch May 4, 2020 14:16
@ApacheEx
Copy link
Author

ApacheEx commented May 6, 2020

"module" property was removed in 2.25.3 (0c709ba)

So, it was the right solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants