New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] './locale' path not found in moment/src/lib/locale/locales.js #5503
Conversation
also, as possible fix: replace |
Can confirm this fixes #5495 the issue and you are the MVP here. Also commit description is not clear in 9ce89e7 |
FYI "module" is supposed to be an ecmascript module and "./moment.js" is a commonjs module. (https://webpack.js.org/guides/author-libraries/#final-steps) |
thanks sir, you save my day 👍 |
Can confirm that this resolves it for us. Can this be merged and released on NPM soon? |
ok guys, I see it's fixed in 2.25.2. So, I'm closing this. |
"module" property was removed in 2.25.3 (0c709ba) So, it was the right solution. |
seems root of issue was introduced here: 9ce89e7
So, this PR reverts it and fixes the following issues:
#4505, #5472, #5497, #5501, #5500, #5378, #5495, #5506, #5508