Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Re-enable ka tests #5536

Closed
wants to merge 2 commits into from
Closed

[bugfix] Re-enable ka tests #5536

wants to merge 2 commits into from

Conversation

marwahaha
Copy link
Member

fixes #4839

@marwahaha marwahaha changed the title Re-enable ka tests [bugfix] Re-enable ka tests May 13, 2020
@coveralls
Copy link

coveralls commented May 17, 2020 •
edited

Coverage Status

Coverage decreased (-0.08%) to 88.347% when pulling 4cfd401 on ka-tests into de98cc4 on develop.

@marwahaha
Copy link
Member Author

Based on nodejs/node#22518 we cannot merge this until we drop Node 10 support.

@marwahaha
Copy link
Member Author

We will not drop Node 10 support, so I will close this.
See https://momentjs.com/docs/#/-project-status/

@marwahaha marwahaha closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable failing ka tests (after we drop node 10)
2 participants
@marwahaha @coveralls