[misc] speedup month & era locale handling #5581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alanscut
changed the title
marwahaha
changed the title
marwahaha
reviewed
Sep 15, 2020
| } | ||
| // Sorting makes sure if one month (or abbr) is a prefix of another it | ||
| // will match the longer piece. | ||
| shortPieces.sort(cmpLenRev); | ||
| longPieces.sort(cmpLenRev); | ||
| mixedPieces.sort(cmpLenRev); | ||
| for (i = 0; i < 12; i++) { |
There was a problem hiding this comment.
This could change functionality, correct?
It's first a sort, then escape. Your change escapes, then sorts.
There was a problem hiding this comment.
regexEscape function may change the length of shortP, longP, and mixedP, leading a wrong sorting, so I changed the order of escapes and sorts
There was a problem hiding this comment.
Do you ever want to sort before you escape the regex?
Does it make sense to test this behavior?
|
Merged in a3babc5 |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Dec 23, 2023
[feature] Optimize computeErasParse and computeMonthsParse
|
I tweaked a bit the eras code, was double-escaping the regex for the mixed case. |
ichernev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Optimize
computeErasParseandcomputeMonthsParse, reduce unnecessary regular escaping and loop traversal.