Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] unify duration.valueOf and asMilliseconds #5607

Closed
wants to merge 1 commit into from
Closed

[bugfix] unify duration.valueOf and asMilliseconds #5607

wants to merge 1 commit into from

Conversation

Alanscut
Copy link
Contributor

Changes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 88.502% when pulling 8484045 on Alanscut:issue_5603 into 3e1a95b on moment:develop.

@Alanscut Alanscut changed the title valueOf and asMilliseconds have the same function [bugfix] valueOf and asMilliseconds have the same function Jun 29, 2020
@marwahaha
Copy link
Member

I am not sure whether to merge this, in case of breaking change.

cc @ichernev

@ichernev ichernev changed the title [bugfix] valueOf and asMilliseconds have the same function [bugfix] unify duration.valueOf and asMilliseconds Dec 26, 2023
@ichernev
Copy link
Contributor

Merged in 8dd12f6

@ichernev ichernev closed this Dec 26, 2023
ichernev added a commit that referenced this pull request Dec 26, 2023
@ichernev
Merge pull request #5607 from Alanscut:issue_5603
8dd12f6 
[bugfix] unify duration.valueOf and asMilliseconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichernev ichernev Awaiting requested review from ichernev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Alanscut @coveralls @marwahaha @ichernev