New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] add readonly typescript interface #5752
base: develop
Are you sure you want to change the base?
Conversation
I don't use TypeScript often anymore; perhaps someone else can review this. |
the CI errors are from prettier on files i didn't modify? weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marwahaha this has 2 approving reviews; someone with merge permissions could probably merge? thank you! |
@forivall you also need to change |
Fixes #4169
The same could also be done for
Duration
but with only 4 mutation methods, it's easier to keep track of when you're modifying.