Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] add readonly typescript interface #5752

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

forivall
Copy link

Fixes #4169

The same could also be done for Duration but with only 4 mutation methods, it's easier to keep track of when you're modifying.

@forivall forivall changed the title feat: add readonly typescript interface [misc] add readonly typescript interface Oct 10, 2020
@marwahaha
Copy link
Member

I don't use TypeScript often anymore; perhaps someone else can review this.

@marwahaha marwahaha closed this Oct 27, 2020
@marwahaha marwahaha reopened this Oct 27, 2020
@coveralls
Copy link

coveralls commented Nov 24, 2020

Coverage Status

Coverage increased (+0.06%) to 88.499% when pulling 84c3e17 on forivall:feat/readonly-typings into e968092 on moment:develop.

@forivall
Copy link
Author

the CI errors are from prettier on files i didn't modify? weird.

Copy link

@FaizzJamaludin FaizzJamaludin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forivall
Copy link
Author

forivall commented Aug 9, 2022

@marwahaha this has 2 approving reviews; someone with merge permissions could probably merge? thank you!

@ichernev
Copy link
Contributor

@forivall you also need to change moment.d.ts and do the Duration as well (otherwise it's inconsistent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] readonly typescript interface
6 participants