Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Graceful handling of undefined locale name #6128

Closed

Conversation

Tobi-Adeneye
Copy link
Contributor

…ane function and ensure it returns a boolean

…ane function and ensure it returns a boolean
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Tobi-Adeneye / name: Oluwatobiloba A. Adeneye (2cbd4ca)

Copy link

@suyundukov suyundukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you passing undefined value here? What is the use case? I think it's up to user to check for the existence of the value before calling isLocaleNameSane.

@suyundukov
Copy link

Duplicate #5987.

@ichernev ichernev changed the title fix(bug): add condition to prevent name is undefined in isLocaleNameS… [feature] Graceful handling of undefined locale name Dec 16, 2023
ichernev added a commit that referenced this pull request Dec 16, 2023
[feature] Graceful handling of undefined locale name
@ichernev
Copy link
Contributor

merged in bcaa012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants