A fix for Ukrainian (uk) language translation #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way in which 'Last %weekday%' calendar dates are written by making it more in line with modern grammar rules, added genitive case for weekdays. Thus fixed an issue with displaying calendar dates as 'Last %weekday%', where nominative case was incorrectly used instead of accusative.
|
Thanks for contributing. The test patch looks ok, but the actual fix also seems to change the file end-of-line to windows format (\r\n). Can you please fix this. @zemlanin what do you think about that? |
|
👍 |
It should be OK now. |
|
Great, thanks for contributing! |
timrwood
added a commit
that referenced
this pull request
Mar 17, 2013
A fix for Ukrainian (uk) language translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made amendments to Ukrainian translation to fix the issue with displaying calendar dates like this:
In the example above 'середа' is in nominative instead of the needed accusative ('середу').
Fixed by changing the format of "Last %weekday%" expression in Ukrainian to the more grammatically accurate, which uses genitive case, like in the example below: