feat: add CacheClient close method (#80)

* feat: add CacheClient close method * remove unused imports from examples
momentohq · Jan 8, 2024 · 411d432 · 411d432
1 parent 6de1b98
commit 411d432
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 7 deletions.
diff --git a/example/quickstart/quickstart.dart b/example/quickstart/quickstart.dart
@@ -1,7 +1,6 @@
-import 'dart:io';
 import 'package:momento/momento.dart';
 
-void main() async {
+Future<void> main() async {
   final cacheClient = CacheClient(
       CredentialProvider.fromEnvironmentVariable("MOMENTO_API_KEY"),
       MobileCacheConfiguration.latest(),
@@ -29,5 +28,5 @@ void main() async {
       print("Got an error: ${getResp.errorCode} ${getResp.message}");
   }
 
-  exit(0);
+  await cacheClient.close();
 }
diff --git a/example/topics/advanced.dart b/example/topics/advanced.dart
@@ -71,5 +71,4 @@ void main() async {
 
   topicClient.close();
   print("End of Momento topics example");
-  exit(0);
 }
diff --git a/example/topics/basic_publisher.dart b/example/topics/basic_publisher.dart
@@ -21,5 +21,4 @@ void main() async {
 
   topicClient.close();
   print("Closed Momento Topics publisher");
-  exit(0);
 }
diff --git a/example/topics/basic_subscriber.dart b/example/topics/basic_subscriber.dart
@@ -1,5 +1,4 @@
 import 'dart:async';
-import 'dart:io';
 import 'package:momento/momento.dart';
 
 void main() async {
@@ -38,5 +37,4 @@ void main() async {
 
   topicClient.close();
   print("Closed Momento Topics subscriber");
-  exit(0);
 }
diff --git a/lib/src/cache_client.dart b/lib/src/cache_client.dart
@@ -22,6 +22,8 @@ abstract class ICacheClient {
       {Duration? ttl});
 
   Future<DeleteResponse> delete(String cacheName, Value key);
+
+  Future<void> close();
 }
 
 class CacheClient implements ICacheClient {
@@ -117,4 +119,10 @@ class CacheClient implements ICacheClient {
     }
     return _dataClient.delete(cacheName, key);
   }
+
+  @override
+  Future<void> close() async {
+    await _dataClient.close();
+    await _controlClient.close();
+  }
 }
diff --git a/lib/src/internal/control_client.dart b/lib/src/internal/control_client.dart
@@ -10,6 +10,8 @@ abstract class AbstractControlClient {
   Future<DeleteCacheResponse> deleteCache(String cacheName);
 
   Future<ListCachesResponse> listCaches();
+
+  Future<void> close();
 }
 
 class ControlClient implements AbstractControlClient {
@@ -83,4 +85,9 @@ class ControlClient implements AbstractControlClient {
       }
     }
   }
+
+  @override
+  Future<void> close() async {
+    await _channel.shutdown();
+  }
 }
diff --git a/lib/src/internal/data_client.dart b/lib/src/internal/data_client.dart
@@ -12,6 +12,8 @@ abstract class AbstractDataClient {
       {Duration? ttl});
 
   Future<DeleteResponse> delete(String cacheName, Value key);
+
+  Future<void> close();
 }
 
 class DataClient implements AbstractDataClient {
@@ -100,4 +102,9 @@ class DataClient implements AbstractDataClient {
       }
     }
   }
+
+  @override
+  Future<void> close() async {
+    await _channel.shutdown();
+  }
 }