chore: ttl should be duration not int

momentohq · Dec 21, 2023 · 87fb164 · 87fb164
1 parent 1f9cb8e
commit 87fb164
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/src/cache_client.dart b/lib/src/cache_client.dart
@@ -12,7 +12,7 @@ abstract class ICacheClient {
   Future<GetResponse> get(String cacheName, Value value);
 
   Future<SetResponse> set(String cacheName, Value key, Value value,
-      {int? ttlSeconds});
+      {Duration? ttl});
 }
 
 class CacheClient implements ICacheClient {
@@ -34,7 +34,7 @@ class CacheClient implements ICacheClient {
 
   @override
   Future<SetResponse> set(String cacheName, Value key, Value value,
-      {int? ttlSeconds}) {
-    return _dataClient.set(cacheName, key, value, ttlSeconds: ttlSeconds);
+      {Duration? ttl}) {
+    return _dataClient.set(cacheName, key, value, ttl: ttl);
   }
 }
diff --git a/lib/src/internal/data_client.dart b/lib/src/internal/data_client.dart
@@ -13,7 +13,7 @@ abstract class AbstractDataClient {
   Future<GetResponse> get(String cacheName, Value key);
 
   Future<SetResponse> set(String cacheName, Value key, Value value,
-      {int? ttlSeconds});
+      {Duration? ttl});
 }
 
 class DataClient implements AbstractDataClient {
@@ -64,12 +64,12 @@ class DataClient implements AbstractDataClient {
 
   @override
   Future<SetResponse> set(String cacheName, Value key, Value value,
-      {int? ttlSeconds}) async {
+      {Duration? ttl}) async {
     var request = SetRequest_();
     request.cacheKey = key.toBinary();
     request.cacheBody = value.toBinary();
-    request.ttlMilliseconds = (ttlSeconds != null
-        ? ttlSeconds * 1000
+    request.ttlMilliseconds = (ttl != null
+        ? ttl.inMilliseconds
         : _defaultTtl.inMilliseconds) as Int64;
     try {
       await _client.set(request,