Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CacheClient close method #80

Merged
merged 2 commits into from
Jan 8, 2024
Merged

feat: add CacheClient close method #80

merged 2 commits into from
Jan 8, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Jan 8, 2024 •
edited

addresses #66

Examples would hang if exit(0) was not called at the end. Added a close method to the CacheClient to free up GRPC resources at the end of a program, so now exit(0) does not have to be called.

@anitarua anitarua marked this pull request as ready for review January 8, 2024 22:13
pgautier404
pgautier404 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anitarua anitarua merged commit 411d432 into main Jan 8, 2024
2 checks passed
@anitarua anitarua deleted the fix-examples-hanging branch January 8, 2024 22:23
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgautier404 pgautier404 pgautier404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anitarua @pgautier404