Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implement toString for non-error response classes #89

Merged
merged 11 commits into from
Jan 10, 2024
Merged

chore: implement toString for non-error response classes #89

merged 11 commits into from
Jan 10, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Jan 10, 2024 •
edited
Loading

addresses #78

Overrode the toString function to show more information by default when non-error response objects are printed out.

Before, print(getResp) would print Instance of GetHit, and now it will print GetHit: value

pgautier404
pgautier404 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anitarua anitarua merged commit d8ff271 into main Jan 10, 2024
2 checks passed
@anitarua anitarua deleted the non-error-tostring branch January 10, 2024 23:29
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgautier404 pgautier404 pgautier404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @pgautier404