Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow heirarchal loggers to have their own log levels #56

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: allow heirarchal loggers to have their own log levels #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/src/cache_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ import 'package:momento/src/config/cache_configuration.dart';
import 'package:momento/src/errors/errors.dart';
import 'package:momento/src/internal/control_client.dart';
import 'package:momento/src/internal/data_client.dart';
import 'package:logging/logging.dart';
import 'package:momento/src/internal/utils/validators.dart';

import 'config/logger.dart';

// import 'config/logger.dart';

abstract class ICacheClient {
Expand All @@ -26,15 +27,14 @@ abstract class ICacheClient {
class CacheClient implements ICacheClient {
late final DataClient _dataClient;
late final ControlClient _controlClient;
final Logger _logger = Logger('MomentoCacheClient');
final MomentoLogger _logger = MomentoLogger('MomentoCacheClient');

CacheClient(CredentialProvider credentialProvider,
CacheConfiguration configuration, Duration defaultTtl) {
_dataClient = DataClient(credentialProvider, configuration, defaultTtl);
_controlClient = ControlClient(credentialProvider, configuration);
// TODO: fix logging level issue
// _logger.level = determineLoggerLevel(configuration.logLevel);
_logger.finest("initializing cache client");
_logger.setLevel(configuration.logLevel);
_logger.trace("initializing cache client");
}

@override
Expand Down
37 changes: 37 additions & 0 deletions lib/src/config/logger.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,40 @@ Level determineLoggerLevel(LogLevel logLevel) {
return Level.OFF;
}
}

class MomentoLogger {
final Logger _logger;

MomentoLogger(String name) : _logger = Logger(name) {
Logger.root.level = Level.ALL;
hierarchicalLoggingEnabled = true;
}

void trace(String message) {
_logger.finest(message);
}

void debug(String message) {
_logger.fine(message);
}

void info(String message) {
_logger.info(message);
}

void warn(String message) {
_logger.warning(message);
}

void error(String message) {
_logger.severe(message);
}

void fatal(String message) {
_logger.shout(message);
}

void setLevel(LogLevel logLevel) {
_logger.level = determineLoggerLevel(logLevel);
}
}
10 changes: 4 additions & 6 deletions lib/src/topic_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'package:momento/src/auth/credential_provider.dart';
// import 'package:client_sdk_dart/src/config/logger.dart';
import 'package:logging/logging.dart';
import 'package:momento/src/config/logger.dart';
import 'config/topic_configuration.dart';
import 'internal/pubsub_client.dart';
import 'messages/responses/topics/topic_subscribe.dart';
Expand All @@ -18,14 +17,13 @@ abstract class ITopicClient {

class TopicClient implements ITopicClient {
final ClientPubsub _pubsubClient;
final Logger _logger = Logger('MomentoTopicClient');
final MomentoLogger _logger = MomentoLogger('MomentoTopicClient');

TopicClient(
CredentialProvider credentialProvider, TopicConfiguration configuration)
: _pubsubClient = ClientPubsub(credentialProvider, configuration) {
// TODO: fix logging level issue
// _logger.level = determineLoggerLevel(configuration.logLevel);
_logger.finest("initializing topic client");
_logger.setLevel(configuration.logLevel);
_logger.trace("initializing topic client");
}

@override
Expand Down