feat: add data client support for list api calls #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
reviewed
Jan 9, 2024
test/src/cache/list_test.dart
Outdated
| expect(fetchResp2.errorCode, | ||
| MomentoErrorCode.invalidArgumentError, | ||
| reason: | ||
| "listFetch should not accept empty cache name"); |
There was a problem hiding this comment.
should say should not accept empty list name right?
There was a problem hiding this comment.
and similar fix for the other strings in this group
anitarua
reviewed
Jan 9, 2024
test/src/cache/list_test.dart
Outdated
| // this is expected | ||
| return; | ||
| case ListFetchError(): | ||
| fail('Expected Miss but got Error'); |
There was a problem hiding this comment.
fail statements should probably print error code and message too
anitarua
reviewed
Jan 9, 2024
test/src/cache/test_utils.dart
Outdated
| case ListFetchMiss(): | ||
| fail('Expected Hit but got Miss'); | ||
| case ListFetchError(): | ||
| fail('Expected Hit but got Error'); |
There was a problem hiding this comment.
fail statements in helper functions should also include error code and message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26
closes #70
closes #71