feat!: Sortedset inconsistencies #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwern
requested review from
malandis,
pgautier404,
eaddingtonwhite and
poppoerika
pgautier404
reviewed
Mar 7, 2023
| func prepareElementValue(name Value) ([]byte, error) { | ||
| if name == nil { | ||
| func prepareElementValue(value Value) ([]byte, error) { | ||
| if value == nil { |
There was a problem hiding this comment.
I think the error below should say "element value cannot be nil" instead?
|
LGTM apart from the question about the error message. |
There's nothing different about values in sorted sets from any other value.
Now takes just a list of values (not elements, and no flags). A sorted set can be deleted with `client.Delete(collectionName)`.
schwern
force-pushed
the
sortedset-inconsistencies
branch
from
38b132e
to
9eb7d6f
Compare
cprice404
pushed a commit
that referenced
this pull request
Mar 14, 2023
* feat!: SortedSetGetRankHit.Rank() and uint64 type conversion. * feat!: SortedSetGetRank takes Value, SortedSetGetScores takes Values. * feat!: SortedSetIncrementScoreSuccess is a type conversion. Add Score(). * feat!: SortedSetRemove takes only values. A sorted set can be deleted with `client.Delete(collectionName)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.delete.Closes #167
Closes #204
Closes #168