Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: SortedSetGetScores polish. #245

Merged
merged 1 commit into from
Mar 8, 2023
Merged

feat!: SortedSetGetScores polish. #245

merged 1 commit into from
Mar 8, 2023

Conversation

schwern
Copy link
Contributor

@schwern schwern commented Mar 7, 2023

  • SortedSetGetScoresHit
    • Make members private
    • Add Scores() accessor
  • SortedSetScoreElement 0> SortedSetGetScore
    • They're not elements, and they're not just scores.

This should be the last SortedSet breaking change.

* SortedSetGetScoresHit
  * Make members private
  * Add Scores() accessor
* SortedSetScoreElement 0> SortedSetGetScore
  * They're not elements, and they're not just scores.
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schwern schwern merged commit e6c8eb2 into main Mar 8, 2023
@schwern schwern deleted the sorted-set-cleanups branch March 8, 2023 19:29
cprice404 pushed a commit that referenced this pull request Mar 14, 2023
* SortedSetGetScoresHit
  * Make members private
  * Add Scores() accessor
* SortedSetScoreElement -> SortedSetGetScore
  * They're not elements, and they're not just scores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants