Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentation): add api-extractore, api-doc, es-lint fixes #27 #55

Conversation

torgeadelin
Copy link
Contributor

Description

Added following packages:

  • api-extractor: generate API metadata
  • api-documenter: using API metadata, generate markdown API for the package
  • eslint-plugin-tsdoc - eslint rule for tsdocs

Also added scripts to generate metadata and the markdown.

Links

#27

@torgeadelin torgeadelin requested a review from a team as a code owner November 2, 2022 17:15
@@ -44,6 +44,7 @@
"eslint-config-airbnb-base": "^15.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-json": "^3.1.0",
"eslint-plugin-tsdoc": "^0.2.17",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a docs script should be added to the main package json

docs script should be added to each package that exists

docs script should be added to the template plop generator

api extractor config should be added to the template plop generator as well as the eslint config

docs script should be added to the list of affected scripts that run so that this will trigger during CI/CD to generate docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re docs script should be added to each package that exists -- tokens package is just a db, it doesn't have any code, only JSON files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re docs script should be added to the template plop generator -- added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re a docs script should be added to the main package json -- added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re api extractor config should be added to the template plop generator as well as the eslint config -- added api-extractor config to plop templates (also fixed some small bugs).
re eslint config to plop -- the es lint rule I've added is global for the monorepo not individual to each package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisadubois ready for re-review

Copy link
Contributor

@chrisadubois chrisadubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it generating so many files? shouldn't these be consolidated ???

@@ -28,6 +28,7 @@ module.exports = {
},
plugins: [
'@typescript-eslint',
'eslint-plugin-tsdoc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -47,6 +48,7 @@ module.exports = {
'max-len': ['error', { code: 120 }],
indent: ['error', 2, { ignoredNodes: ['PropertyDefinition'], SwitchCase: 1 }],
'object-curly-newline': 'off',
'tsdoc/syntax': 'warn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@torgeadelin torgeadelin mentioned this pull request Nov 3, 2022
2 tasks
chrisadubois
chrisadubois previously approved these changes Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants