Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Changes: Stable Token Update (06/27/2024) #640

Merged
merged 131 commits into from
Jun 27, 2024
Merged

Breaking Changes: Stable Token Update (06/27/2024) #640

merged 131 commits into from
Jun 27, 2024

Conversation

seheekim1009
Copy link
Contributor

@seheekim1009 seheekim1009 commented Jun 12, 2024 •
edited by cscheffauer
Loading

Description

ATTENTION: Contains Breaking Changes!

Token Updates (06/27/2024)

  • Switched to new Automation using Figma Variables, implications:
    • 2.0 (Next) tokens will be excluded, will be added back later (do not update to this version if u rely on those tokens)
    • Type, Border radius, spacing and other tokens will be excluded, will be added back later (do not update to this version if u rely on those tokens)
  • Added Common Tokens to High Contrast Themes
  • Changes to Stable Theme Tokens:
    • Gradients are no longer exported as "linear-gradient", but with Gradient-0, Gradient-1 values. This will change in the future. If
    • There will be no issues anymore between dark & light theme that values are missing in one theme vs the other.
  • Cleanup of Documention
    • Including High contrast themes to docs
    • Added CSS Variable information to token table
    • Added filename information to token table

Links

https://www.figma.com/design/yYfvFEEr3UkW1yUKkW7zEH/💎-Theme---Color?node-id=861-6638&t=7FSsjc4E3QJ0Nyd6-11

tricarro and others added 30 commits December 6, 2022 19:45
@tricarro
Updated border-radius meta data.
40ba4a3
@seheekim1009
Theme & common token updates
b7ca49d 
- Moved 9 Illustration colors into common tokens as they have the same value.
- Moved illustration under "content" tokens. 
- Fixed some descrtions for consistency between dark & light mode. 

Ready for review ;)
@seheekim1009
Common Token Update
8fd7087 
-Updated description of surface.decorative tokens
@seheekim1009
Theme Token Update
43ef1ea 
- Corrected incorrect naming in Illustration tokens in Common Theme
- Added text.secondary token in Common Theme
@seheekim1009
Border Radius Update
d0830fa 
-erased typo (butzz) in the description on the Border-radius small.
@chrisadubois
fix(schema): update common.json schema
c21b909
@chrisadubois
fix(schema): update dark json schema
4289b19
@chrisadubois
fix(schemas): update light json schema
56c3bce
@seheekim1009
Common Theme Update
74eebb1 
-No structral change, edited description for content.indicators.
@chrisadubois
Merge branch 'main' into design-token-updates
02b7bc9
@tricarro
Updated Border Radius tokens to include a border-radius.none value of…
f6c70d0 
… 0px.
@tricarro
Updated Border Width Design Tokens with a border-width.none that has …
f5ba44b 
…a value of 0px.
@tricarro
Updated the Spacing Design Tokens with a spacing.none token with a va…
2d4bf69 
…lue of 0px.
@seheekim1009
Theme Token Update
9ec1320 
-Added 6 contrast tokens for inverted text/buttons in Dark & Lighth theme. You can refer
 color.theme.content.text.contrast.neutral 
 color.theme.content.btn.contrast.neutral 

Ready to review
@InteractiveTimmy
fix(token-builder/schema): update light schema
d0094d5
@InteractiveTimmy
fix(token-builder/schema): update dark schema
eecc98b
@InteractiveTimmy
fix(token-builder/schema): update spacing schema
bc87385
@InteractiveTimmy
fix(token-builder/schema): update border-width
89747dd
@InteractiveTimmy
fix(token-builder/schema): update border radius
02e8090
@InteractiveTimmy
Merge branch 'main' into design-token-updates
efa693b
@InteractiveTimmy
Merge branch 'main' into design-token-updates
9b4d9e3
@InteractiveTimmy
Merge branch 'main' into design-token-updates
06e0f3b
@tricarro
Adding Elevation, Border Radius, Border Width, and Spacing as Theme T…
f39173d 
…okens.
@tricarro
Adding Border Radius Theme Tokens.
467bd04
@tricarro
Adding Border Width Theme Tokens
f7a982a
@tricarro
Added Spacing Tokens.
0dbf12e
@InteractiveTimmy
Merge branch 'main' into design-token-updates
a0561f2
@seheekim1009
Updated HEX values of Orange core colors to fix the accessibility bug…
ac7a818 
… reported by the Realtime team.
@tricarro
Fixing issue with Border Width naming.
1ed4187
@tricarro
Updating Core Tokens
d563b93
seheekim1009 and others added 17 commits March 26, 2024 10:01
@seheekim1009
Token Update (03/26/2024)
4fc2cff 
: Core Token Update for HC
@seheekim1009
03/26/2024
3dad0d5 
Token Update
@nataliadelmar
Merge branch 'main' into design-token-updates
daf9e3d
@tricarro
Test token update.
d3b9c82
@tricarro
Test github update.
468b1e5
@tricarro
Updates to stable tokens.
b951de1
@seheekim1009
H.C token update (05/23/2024)
4b1d413 
-Updated H.C black / white in theme tokens.
@cscheffauer
Merge branch 'main' into design-token-updates
4a91112
@seheekim1009
Token Update (06/05/2024) - DUI/LUI/Common
5cd149d 
Multiple updates in Stable Tokens.
@seheekim1009
Core Token Update (06/05/2024)
d266ed2 
- Corrected HEX value for black-alpha
@seheekim1009
Core Token Update (06/05/2024)
dd88123 
-Corrected black-alpha.46 HEX code
@cscheffauer
Merge branch 'main' into design-token-updates
482659d
@seheekim1009
Color Token Update (06/06/2024)
dcb8edb 
-Created following tokens:
 - OverlayButtonSecondary-normal
 - OverlayButtonSecondary-hover
 - OverlayButtonSecondary-pressed
@seheekim1009
Theme Token Update (06/11/202)
bca5e26 
Stable Token Updates
@seheekim1009
Theme Token Update (06/11/2024)
baaca13 
[Common] Updated content.doc
@cscheffauer
Merge branch 'main' into design-token-updates
93cf3a0
@seheekim1009
Theme Token Update (06/12/2024)
13449e7 
Stable Token updates

[DUI/LUI] Removed ButtonBorder-normal
[DUI/LUI] Updated following token:
 OutlineDisabled-normal ➡️ OutlinePrimary-disabled
@seheekim1009 seheekim1009 requested a review from a team as a code owner June 12, 2024 22:24
seheekim1009 and others added 6 commits June 14, 2024 08:35
@seheekim1009
Theme Token Update (06/14/2024)
29370b6 
Variables created - Dark/ Light
@seheekim1009
06/14/2024
f70f922 
Created Core Variables
@seheekim1009
06/14/2024
fa26428 
Variable test - corrected core to "color"
@seheekim1009
06/24/2024
d758f1d 
Variable Structure Test
@seheekim1009
Token Update (06/26/2024)
c754ca5 
Converted following color tokens to variables
- Core
- Stable (dark/light)
- Common (black/white/common)
- AAOS (night/day)
@cscheffauer
fix: config and docs
53ef0d9
@cscheffauer cscheffauer requested a review from a team as a code owner June 27, 2024 09:42
@cscheffauer cscheffauer changed the title Stable Token Update (06/12/2024) Breaking Changes: Stable Token Update (06/27/2024) Jun 27, 2024
@cscheffauer cscheffauer merged commit 4fbc4a8 into main Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@seheekim1009 @cscheffauer @tricarro @chrisadubois @InteractiveTimmy @nataliadelmar