Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

savelocs dont save after reloading map with -hijack #1281

Closed
granis48 opened this issue Apr 3, 2021 · 6 comments
Closed

savelocs dont save after reloading map with -hijack #1281

granis48 opened this issue Apr 3, 2021 · 6 comments
Assignees
Labels
Outcome: Resolved This was resolved, and will be in a future update. Priority: High Something essential that should be done in this release, as soon as possible. Type: Bug Something that should work/look one way isn't quite doing that.

Comments

@granis48
Copy link
Member

granis48 commented Apr 3, 2021

I'm making a map and made a whole bunch of savelocs, when recompiling and running the $game_exe thing with -hijack it reloaded map like it's supposed to but all savelocs disappeared. plz fix.

on chaos steam version

edit: did the same thing again and now the savelocs saved, gonna test some more

@granis48 granis48 added the Type: Bug Something that should work/look one way isn't quite doing that. label Apr 3, 2021
@granis48
Copy link
Member Author

granis48 commented Apr 3, 2021

ok i cant seem to reproduce it, dunno what happened so im just gonna close this

@granis48 granis48 closed this as completed Apr 3, 2021
@Gocnak
Copy link
Member

Gocnak commented Apr 3, 2021

If it happens again definitely try to get the steps for it! Savelocs are saved on map shutdown, so if -hijack is not properly shutting down the map then it could not save them.

@granis48
Copy link
Member Author

granis48 commented Apr 10, 2021

I found out how to replicate it!

It will never save new locs that are started with the timer running. however if i disable the timer and create a saveloc, it will save after reload.

To replicate yourself:

  • make a map and zone it
  • create some savelocs with the timer running
  • recompile map and launch game with the -hijack parameter
  • watch the savelocs disappear

Any savelocs made without timer will stay like normal after reload.
Only happens if timer is running when you make the savelocs.
Normal reloads (reload, retry or reopening the map) do not have this issue.

@granis48 granis48 reopened this Apr 10, 2021
@Gocnak Gocnak added the Priority: High Something essential that should be done in this release, as soon as possible. label Apr 16, 2021
@Gocnak Gocnak added this to To Do in 0.9.0 Release via automation Apr 16, 2021
@braem
Copy link
Member

braem commented Apr 30, 2021

Something similar is happening to @Road2SilverEagleMaster in Discord. Savelocs aren't saving for them when reloading a map manually after it compiles (not using -hijack). Also happens for them with timer off. They are using hammer++.

See https://discord.com/channels/235111289435717633/356398721790902274/837629785914998794

I'm wondering if hammer is doing something when compiling a map that you are currently on which prevents shutdown from being called. Or maybe just changing the map file at all?

@Gocnak Gocnak self-assigned this May 10, 2021
@Gocnak Gocnak moved this from To Do to In Progress in 0.9.0 Release May 10, 2021
@Gocnak
Copy link
Member

Gocnak commented May 10, 2021

Found out why it happened, was a missing check in the engine. Should be fixed in the next push.

@Gocnak Gocnak added the Blocked: Needs testing & verification Needs testing and verification if properly fixed. label May 10, 2021
@Gocnak Gocnak added Outcome: Resolved This was resolved, and will be in a future update. and removed Blocked: Needs testing & verification Needs testing and verification if properly fixed. labels May 17, 2021
@Gocnak
Copy link
Member

Gocnak commented May 17, 2021

Savelocs should properly save on level shutdown, either through hijack or even the map command.

@Gocnak Gocnak closed this as completed May 17, 2021
0.9.0 Release automation moved this from In Progress to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Outcome: Resolved This was resolved, and will be in a future update. Priority: High Something essential that should be done in this release, as soon as possible. Type: Bug Something that should work/look one way isn't quite doing that.
Projects
No open projects
0.9.0 Release
  
Done
Development

No branches or pull requests

3 participants