Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mom_release_forward_on_jump broken on Chaos #1340

Closed
tsa96 opened this issue May 21, 2021 · 1 comment
Closed

mom_release_forward_on_jump broken on Chaos #1340

tsa96 opened this issue May 21, 2021 · 1 comment
Assignees
Labels
Outcome: Resolved This was resolved, and will be in a future update. Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Trivial Something that is estimated to be only a few lines of code or will take minutes to do. "Quick Wins" Type: Bug Something that should work/look one way isn't quite doing that. Where: Game This is something for the main game code.

Comments

@tsa96
Copy link
Member

tsa96 commented May 21, 2021

Describe the bug
mom_release_forward_on_jump 1 on Chaos will fail to work and print the error

FCVAR_CLIENTCMD_CAN_EXECUTE prevented running command: -forward
Tried to look up command -forward as if it were a variable.

when jumping and either +forward or +back keys are being held. Note that everything behaves fine on 0.8.7

To Reproduce
Just set mom_release_forward_on_jump 1 and try jumping whilst holding a movement key on any map.

Expected behavior
Jumping should fire -forward or -back if either of those keys are being held.

Desktop/Branch (please complete the following information):

  • OS: Windows
  • Branch: Steam

Additional context
Credit to esox in Discord for the find :)

@tsa96 tsa96 added the Type: Bug Something that should work/look one way isn't quite doing that. label May 21, 2021
@lvaness lvaness self-assigned this May 23, 2021
@Gocnak Gocnak added this to To Do in 0.9.0 Release via automation May 24, 2021
@Gocnak Gocnak added Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Trivial Something that is estimated to be only a few lines of code or will take minutes to do. "Quick Wins" Where: Game This is something for the main game code. labels May 24, 2021
@Gocnak Gocnak moved this from To Do to In Progress in 0.9.0 Release May 27, 2021
@Gocnak Gocnak added the Blocked: Needs testing & verification Needs testing and verification if properly fixed. label May 29, 2021
@lvaness lvaness moved this from In Progress to Done in 0.9.0 Release May 30, 2021
@lvaness lvaness added Outcome: Resolved This was resolved, and will be in a future update. and removed Blocked: Needs testing & verification Needs testing and verification if properly fixed. labels May 30, 2021
@lvaness lvaness closed this as completed May 30, 2021
@lvaness
Copy link
Member

lvaness commented May 30, 2021

Reported as working on Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Outcome: Resolved This was resolved, and will be in a future update. Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Trivial Something that is estimated to be only a few lines of code or will take minutes to do. "Quick Wins" Type: Bug Something that should work/look one way isn't quite doing that. Where: Game This is something for the main game code.
Projects
No open projects
0.9.0 Release
  
Done
Development

No branches or pull requests

3 participants