Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent concs from spamming collision sound #1347

Closed
zike1017 opened this issue May 29, 2021 · 2 comments
Closed

Prevent concs from spamming collision sound #1347

zike1017 opened this issue May 29, 2021 · 2 comments
Assignees
@Gocnak
Labels
Outcome: Resolved This was resolved, and will be in a future update. Size: Small Something that may take a day at most to do. Type: Bug Something that should work/look one way isn't quite doing that. Where: Game This is something for the main game code.
Projects
0.9.0 Release

Comments

@zike1017
Copy link

Describe the bug
When concs hit a surface many times in rapid succession the sound effect is played excessively.

To Reproduce
Easiest way to produce this is to throw a conc into a push trigger that pushes concs down towards the ground like on conc_ninja.
https://streamable.com/d2mngg

Expected behavior
The conc should only play the collision sound once.

Desktop/Branch (please complete the following information):

  • OS: Windows
  • Branch: Steam version
@zike1017 zike1017 added the Type: Bug Something that should work/look one way isn't quite doing that. label May 29, 2021
@Gocnak Gocnak self-assigned this May 30, 2021
@Gocnak Gocnak added Blocked: Needs testing & verification Needs testing and verification if properly fixed. Size: Small Something that may take a day at most to do. Where: Game This is something for the main game code. labels May 30, 2021
@Gocnak Gocnak added this to To Do in 0.9.0 Release via automation May 30, 2021
@Gocnak Gocnak moved this from To Do to In Progress in 0.9.0 Release May 30, 2021
@Gocnak
Copy link
Member

Gocnak commented May 30, 2021

Implemented. Controllable via momentum-mod/docs#190 convars. Conc bounce sounds only occur if the grenade is moving/moved from its last bounce location. Needs testing, should be in latest push.

@Gocnak
Copy link
Member

Gocnak commented Jun 3, 2021

Was the implementation good enough? Can close if so.

@Gocnak Gocnak added Outcome: Resolved This was resolved, and will be in a future update. and removed Blocked: Needs testing & verification Needs testing and verification if properly fixed. labels Jun 9, 2021
@Gocnak Gocnak closed this as completed Jun 9, 2021
0.9.0 Release automation moved this from In Progress to Done Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gocnak Gocnak

Labels
Outcome: Resolved This was resolved, and will be in a future update. Size: Small Something that may take a day at most to do. Type: Bug Something that should work/look one way isn't quite doing that. Where: Game This is something for the main game code.
Projects
No open projects
0.9.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gocnak @zike1017