Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebinding the console key will still require ` to close the panel #1479

Closed
hexaflexahexagon opened this issue Aug 6, 2021 · 1 comment
Closed

Rebinding the console key will still require ` to close the panel #1479

hexaflexahexagon opened this issue Aug 6, 2021 · 1 comment
Assignees
@lvaness
Labels
Outcome: Resolved This was resolved, and will be in a future update. Type: Bug Something that should work/look one way isn't quite doing that.
Projects
0.9.1 Release
Milestone
Panorama

Comments

@hexaflexahexagon
Copy link
Member

Describe the bug
Rebinding your console key to anything but ` will allow you to open the console using that new key but you will have to use the old bind again to close it.

To Reproduce
Steps to reproduce the behavior:

  1. bind "KP_DOWNARROW" "toggleconsole"
  2. unbind `
  3. Open console using KP_DOWNARROW, you can't close the console again
  4. Use ` to close the console

Expected behavior
The new bind should work fully.

Desktop (please complete the following information):
Windows, Dx11, Panorama
@hexaflexahexagon hexaflexahexagon added the Type: Bug Something that should work/look one way isn't quite doing that. label Aug 6, 2021
@lvaness lvaness added this to the Panorama milestone Aug 6, 2021
@lvaness lvaness mentioned this issue Sep 11, 2021
Closed
13 tasks
@lvaness lvaness self-assigned this Sep 30, 2021
@lvaness lvaness added this to To Do in 0.9.1 Release via automation Sep 30, 2021
@lvaness lvaness moved this from To Do to In Progress in 0.9.1 Release Sep 30, 2021
@lvaness lvaness added the Blocked: Needs testing & verification Needs testing and verification if properly fixed. label Oct 5, 2021
@hexaflexahexagon
Copy link
Member Author

i think panorama console just works differently (escape closes the console and you can type ` / whatever the bind is) but i'll consider this resolved since you don't have the dependency on ` anymore

0.9.1 Release automation moved this from In Progress to Done Oct 14, 2021
@hexaflexahexagon hexaflexahexagon added Outcome: Resolved This was resolved, and will be in a future update. and removed Blocked: Needs testing & verification Needs testing and verification if properly fixed. labels Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvaness lvaness

Labels
Outcome: Resolved This was resolved, and will be in a future update. Type: Bug Something that should work/look one way isn't quite doing that.
Projects
No open projects
0.9.1 Release
  
Done
Milestone
Panorama
Development

No branches or pull requests
2 participants
@lvaness @hexaflexahexagon