Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gamemode arg to "map" command #2136

Open
tsa96 opened this issue Mar 31, 2024 · 2 comments
Open

Add gamemode arg to "map" command #2136

tsa96 opened this issue Mar 31, 2024 · 2 comments
Assignees
Labels
Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Small Something that may take a day at most to do. Where: Game This is something for the main game code.

Comments

@tsa96
Copy link
Member

tsa96 commented Mar 31, 2024

The map command should take a second argument that sets the gamemode the map is loaded in. It should support autocomplete and ideally translate terms like "surf" into the corresponding value in the gamemodes enum.

We've been talking about this internally a lot of already and found the implementation harder than expected, so Panzer has stopped working on it for now, so I'm getting it tracked here. Existing functionality around parsing keyvalues from arguments passed to this command make it quite difficult to alter for Momentum. rio brought up a possible approach in #mom-dev on 26/03/2024 (not linking here, but search we can implement special map command behavior in Discord to find it).

@jason-e do you want to tackle this, seeing as @Panzerhandschuh isn't keen?

@tsa96 tsa96 added Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Small Something that may take a day at most to do. Where: Game This is something for the main game code. labels Mar 31, 2024
@Mac-tf2
Copy link
Member

Mac-tf2 commented Mar 31, 2024

Without the second arguement are we defaulting to map prefix mode?

@tsa96
Copy link
Member Author

tsa96 commented Apr 1, 2024

I have to admit, whilst we've discussed this several times, I still can't remember what we concluded. The prefix was going to play a role I think, but we were also gonna check the static cache?

@jason-e if you could clarify your suggestions here that'd be great, sorry to bring up again but let's get it written down once and for all

@BIRD311 BIRD311 self-assigned this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Small Something that may take a day at most to do. Where: Game This is something for the main game code.
Projects
None yet
Development

No branches or pull requests

3 participants