Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paint decals can overwrite most recent decal when at maximum decal count #243

Closed
Beetle179 opened this issue May 18, 2019 · 3 comments
Closed

Paint decals can overwrite most recent decal when at maximum decal count #243

Beetle179 opened this issue May 18, 2019 · 3 comments
Labels
Outcome: Resolved This was resolved, and will be in a future update. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. Type: Bug Something that should work/look one way isn't quite doing that. Where: Engine This is something that will be done in the base engine.
Projects
0.9.0 Release

Comments

@Beetle179
Copy link
Collaborator

Likely related to max decals (r_decals, mp_decals). seems like after some point (probably reaching max decals), new decals will overwrite the most recent decal, instead of overwriting the oldest decal.

https://clips.twitch.tv/ShakingAffluentRingJonCarnage

Submitted by Beetle179
@Beetle179 Beetle179 added Type: Bug Something that should work/look one way isn't quite doing that. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. labels May 18, 2019
@Gocnak
Copy link
Member

Gocnak commented May 18, 2019

The thing about decals is, we use the FDECAL_PERMANENT flag on paint to make it so your paint persists, can exist in the same area as other decals, and has a higher limit than normal decals.

The unfortunate side effects of this flag means that your paint cannot be removed unless you reload the map, and now this. The kicker is, it's all in engine. So unless we roll our own decal system, or get engine access, this will have to be backburner.

@Gocnak Gocnak added the Where: Engine This is something that will be done in the base engine. label May 21, 2019
@Gocnak Gocnak changed the title Paint decals can overwrite most recent decal Paint decals can overwrite most recent decal when at maximum decal count May 21, 2019
@braem braem mentioned this issue Jul 30, 2020
Closed
@Gocnak Gocnak added this to To Do in 0.9.0 Release via automation Mar 19, 2021
@Gocnak Gocnak added the Blocked: Needs testing & verification Needs testing and verification if properly fixed. label Mar 19, 2021
@Gocnak Gocnak moved this from To Do to In Progress in 0.9.0 Release Mar 19, 2021
@Gocnak
Copy link
Member

Gocnak commented Mar 19, 2021

Does this still happen? We made paint no longer permanent on Chaos, so ideally it should start to remove the paint you placed a while ago.

@hexaflexahexagon
Copy link
Member

the oldest paint decal is now properly removed rather than the most recent one.

0.9.0 Release automation moved this from In Progress to Done Mar 19, 2021
@Gocnak Gocnak added Outcome: Resolved This was resolved, and will be in a future update. and removed Blocked: Needs testing & verification Needs testing and verification if properly fixed. labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Outcome: Resolved This was resolved, and will be in a future update. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. Type: Bug Something that should work/look one way isn't quite doing that. Where: Engine This is something that will be done in the base engine.
Projects
No open projects
0.9.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gocnak @Beetle179 @hexaflexahexagon