Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader override fails when another game's bin folder is in PATH #832

Closed
SlidyBat opened this issue Jul 11, 2020 · 1 comment
Closed

Shader override fails when another game's bin folder is in PATH #832

SlidyBat opened this issue Jul 11, 2020 · 1 comment
Labels
Type: Bug Something that should work/look one way isn't quite doing that. Where: Engine This is something that will be done in the base engine.

Comments

@SlidyBat
Copy link
Member

Describe the bug
To override shaders we rely on the stdshader*.dll files not existing. However, some users, mostly mappers, have other game's bin folder in their PATH which makes the engine try to load stdshader*.dll from there.

To Reproduce
Add a bin folder that contains stdshader*.dll to your PATH envvar. For example you could add C:\Program Files (x86)\Steam\steamapps\common\Team Fortress 2\bin. Try running Momentum and you'll get a launch error about overriding shaders.

Expected behavior
People have the bin folder in their PATH in order to use the mapping tools in the command line from anywhere. Ideally we shouldn't interfere with this and allow running Momentum regardless of what the user has in their PATH.

Potential fix
We could add logic in the game to remove other source engine games bin folders from the PATH at runtime. Would have to make sure that this happens before the engine loads the stdshader DLLs.

@SlidyBat SlidyBat added the Type: Bug Something that should work/look one way isn't quite doing that. label Jul 11, 2020
@xen-000 xen-000 added the Where: Engine This is something that will be done in the base engine. label Jul 11, 2020
@Gocnak
Copy link
Member

Gocnak commented Jan 15, 2021

Engine access fixed this. Closing.

@Gocnak Gocnak closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something that should work/look one way isn't quite doing that. Where: Engine This is something that will be done in the base engine.
Projects
None yet
Development

No branches or pull requests

3 participants